Skip to content

Remove Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.dll from PowerShell core #4149

Closed

Description

This is a follow-up issue of #3649
After refactoring PowerShell assembly load context, we actually don't need Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.dll anymore -- the remaining logic/functionality of this dll should be moved to System.Management.Automation.dll (S.M.A.dll depends on AssemblyLoadContext.dll today).
This might affect DSC because the DSC host is still depending on AssemblyLoadContext.dll, so we should communicate with DSC team on this to make sure nothing breaks.

Tasks

  • Remove Microsoft.PowerShell.CoreCLR.AssemblyExtensions.LoadFrom(string assemblyPath) once the PackageManagement module is migrated to .NET Core 2.0.
  • Removing Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.dll completely.

Activity

  1. whatevergeek commented on Aug 23, 2017

    @whatevergeek

    hi! any updates on this?
    I'm trying to build powershell for linux.
    It's failing for:
    error CS0534: 'PowerShellAssemblyLoadContext' does not implement inherited abstract member 'AssemblyLoadContext.Load(AssemblyName)'

    Any workaround for now?

  2. iSazonov commented on Aug 23, 2017

    @iSazonov
    Collaborator

    Paul (@whatevergeek) Please open new Issue with repo steps.

  3. whatevergeek commented on Aug 23, 2017

    @whatevergeek

    Ilya (@iSazonov)
    someone suggested if i can get a fresh repo
    as they said travics CI is passing.
    I'll try that.
    If issue still persist, i'll open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Resolution-FixedThe issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtime

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions