Get-FormatData quietly ignores non-existing type-name arguments #4235

Activity

1. Steve Lee (SteveL-MSFT)

   added

   Area-Cmdlets-Utility

   Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors

   on Jul 13, 2017
2. faraazahmad commented on Jul 27, 2018

   

   Syed Faraaz Ahmad (faraazahmad)

   on Jul 27, 2018

   Contributor

   More actions

   I would like to work on this
3. faraazahmad commented on Jul 28, 2018

   

   Syed Faraaz Ahmad (faraazahmad)

   on Jul 28, 2018

   Contributor

   More actions

   Michael Klement (@mklement0) Steve Lee (@SteveL-MSFT) What should the ErrorCategory be?
4. mklement0 commented on Jul 29, 2018

   

   Michael Klement (mklement0)

   on Jul 29, 2018

   ContributorAuthor

   More actions

   Syed Faraaz Ahmad (@faraazahmad):

   Thanks for your willingness to take this on.

   I'm not the best person to ask, but looking at the enumeration values at https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.errorcategory?view=powershellsdk-1.1.0, perhaps ResourceUnavailable?

   👍React with 👍1Reacted by Syed Faraaz Ahmad
5. SteveL-MSFT commented on Jul 30, 2018

   

   Steve Lee (SteveL-MSFT)

   on Jul 30, 2018

   Member

   More actions

   Syed Faraaz Ahmad (@faraazahmad) consider it yours! Thanks!

   🎉React with 🎉1Reacted by Syed Faraaz Ahmad
6. faraazahmad commented on Jul 31, 2018

   

   Syed Faraaz Ahmad (faraazahmad)

   on Jul 31, 2018

   Last edited by faraazahmad

   Contributor

   More actions

   So my code now outputs this:

   PS /home/faraaz> Get-FormatData yolo
   Get-FormatData : No such type
   At line:1 char:1
   + Get-FormatData yolo
   + ~~~~~~~~~~~~~~~~~~~
   + CategoryInfo          : ResourceUnavailable: (System.String[]:String[]) [Get-FormatData], Exception
   + FullyQualifiedErrorId : SPECIFIED_TYPE_NOT_FOUND,Microsoft.PowerShell.Commands.GetFormatDataCommand
   

   Is this all right? And should I just check for $? in the test or something more?
   :)
7. Jaykul commented on Aug 9, 2018

   

   Joel Bennett (Jaykul)

   on Aug 9, 2018

   Last edited by Jaykul

   Contributor

   More actions

   HANG ON ... This is a breaking change to the function!!!

   Does -ErrorAction SilentlyContinue work, or are you now forcing everyone to wrap this in a try/catch block?

   I understand the desire to have this produce an error, but we can't make existing commands throw exceptions in use cases that used to just return nothing.

   You're breaking every instance of existing code that looks like this, right?

   if(!(Get-FormatData $Type)) {
      Update-FormatData -TypeName $Type ...
   }

   👍React with 👍1Reacted by Mark Kraus
8. Ilya (iSazonov)

   closed this as completedin #7434on Aug 10, 2018
9. Ilya (iSazonov)

   added

   Resolution-FixedThe issue is fixed.The issue is fixed.

   on Aug 16, 2018
10. Ryan Yates (kilasuit)

    added

    WG-Cmdletsgeneral cmdlet issuesgeneral cmdlet issues

    and removed

    WG-Cmdlets-Utility

    on Jul 17, 2026