Skip to content

Reduce scope of File Encoding RFC implementation #4878

Closed

Description

I would like to suggest a staged approach for https://github.com/PowerShell/PowerShell-RFC/blob/master/2-Draft-Accepted/RFC0020-DefaultFileEncoding.md

By removing the support for WindowsLegacy as an encoding type and removing the support for PSDefaultFileEncoding, I believe we can satisfy the bulk of our customers by standardizing our various encoding parameter types to a single type System.Text.Encoding and provide a default encoding of UTF-8 without bom. A type forwarder could be constructed to support the string UTF-8WITHBOM to be a utf-8 encoding with BOM. We can use the current code when appending to a file and encoding is not specified.

If customer demand for WindowsLegacy is strong, we can implement that at a later date. This provides a staged approach while producing the breaking change earlier to gather feedback

Activity

  1. joeyaiello commented on Sep 21, 2017

    @joeyaiello
    Contributor

    Formal ack, I'm good with it.

  2. added
    Committee-ReviewedPS-Committee has reviewed this and made a decision
    and removed
    Review - CommitteeThe PR/Issue needs a review from the PowerShell Committee
    on Sep 23, 2017
  3. added this to the milestone on Sep 23, 2017
  4. SteveL-MSFT commented on Sep 23, 2017

    @SteveL-MSFT
    Member

    @PowerShell/powershell-committee reviewed this and agreed on the proposal

  5. JamesWTruher commented on Oct 31, 2017

    @JamesWTruher
    CollaboratorAuthor

    this was addressed byhttps://github.com//pull/5080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Committee-ReviewedPS-Committee has reviewed this and made a decision

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions