Skip to content

Refactor Web Cmdltes Tests #5669

Closed
Closed

Description

I thought I had an open issue for this already, but I do not.

The Web cmdlets tests need attention. During the course of moving tests to WebListener, quite a few redundant, unnecessary, broken, or unclear tests were found. Each test needs to be verified that it is still relevant, works properly (isn't checking $null -eq $null), and is sufficiently testing what it claims to test. Additionally, there are several foreach loops and we should look at refactoring those to -TestCases. Also, several tests are labeled pending or skipped by logic which may be horrible to test, so each skip/pending/logic gate needs to be evaluated for accuracy.

Finally, The tests need to be cleaned up. I'm recommending the tests be standardized on OTBS or Stoustrup so they can blend in better with Pester. Switching between pester's OTBS/Stroustrup requirement and Allman for logic is ugly and makes the code hard to read and raises the bar for community contributions (having to code to multiple styles at once).

Some of the functions helper functions are redundant and might be suited better as in a module to make it easier to test a la carte.

region's should also become context's

Fix BeExactly -> Be for integers

Activity

  1. microsoft-github-policy-service commented on Nov 16, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

  2. microsoft-github-policy-service commented on Nov 16, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

  3. microsoft-github-policy-service commented on Nov 16, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

  4. microsoft-github-policy-service commented on Nov 23, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Resolution-No ActivityIssue has had no activity for 6 months or more

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions