Skip to content

MshHostUserInterface.cs: Race condition referencing and setting systemTranscript field. #5799

Closed

Description

Currently, the systemTranscript field is updated by StopAllTranscribing and GetSystemTranscriptOption; however, GetSystemTranscriptOption updates the field within a lock but returns the field value outside the lock. From the code, the implication is the value just set in the field should also be returned but a race can occur with StopAllTranscribing that can result in a null reference being returned.

Steps to reproduce

Code review

Expected behavior

Either a comment clarify the intent or function should return the updated field value.

Actual behavior

Not deterministic

Environment data

PSVersion 6.1.0-preview.535
PSEdition Core
GitCommitId v6.1.0-preview.535
OS Microsoft Windows 10.0.17070
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0

Activity

  1. added
    WG-Enginecore PowerShell engine, interpreter, and runtime
    Issue-BugIssue has been identified as a bug in the product
    on Jan 5, 2018
  2. microsoft-github-policy-service commented on Nov 16, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

  3. microsoft-github-policy-service commented on Nov 16, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

  4. microsoft-github-policy-service commented on Nov 23, 2023

    @microsoft-github-policy-service
    Contributor

    This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIssue has been identified as a bug in the productResolution-No ActivityIssue has had no activity for 6 months or moreWG-Enginecore PowerShell engine, interpreter, and runtime

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions