Repository navigation
start menu folder includes version number #5884
Description
Activity
Yes, it is for side-by-side installs - you can easily install preview versions side-by-side with the release version.
I believe the start menu folder and directory names is good until anybody discover a broken scenario.Well, may I suggest just removing the hyphen then? Probably looks better :)
The reason why there is a folder is not only side by side but also that the folder can contain e.g. an x64 and x86 version. For 6.0 it is a known issue that the start menu will contain only either x64 or x86 but this has already been fixed for the upcoming version. But I think we can consider replacing the dash with a space (I removed the dash already from the short cut name itself already). It is good to include the full version because it makes it easy for non-technical people to figure out their exact version should a patch be required at some point (e.g. due to new security vulnerabilities in .Net Core).
Benjamin Staneck (@Stanzilla) The fix with the hyphen would be very easy. Do you want to do it yourself? The fix would be on this line to replace the
ProductSemanticVersionWithNamevariable withProductSemanticVersionWithNameAndOptionalArchitecture
You can simply push that fix to your branch and on the AppVeyor build you can download the artifacts to test your fix before submitting the PR.Christoph Bergmeister (@bergmeister) Here, right?
Line 28 in bb09b88
No, line 178 as per the link in my comment.
I installed the 6.0 release and the start menu folder that is created is called
PowerShell-6.0.0will the folder name change with future versions? Is this because side-by-side installs are possible? Wouldn't it be better to just have it calledPowerShell 6? The dash makes it look a bit weird as well.