Skip to content

vbscript in MSI fails #6095

Closed
Closed
vbscript in MSI fails#6095
Labels
Issue-BugIssue has been identified as a bug in the productResolution-FixedThe issue is fixed.

Description

@TravisEz13
Travis Plunk (TravisEz13)
opened on Feb 3, 2018

Steps to reproduce

build and run MSI from master branch

Expected behavior

msi should install without error

Actual behavior

image

Log Excerpt

Action 18:10:37: SaveShortcutPath.
Action start 18:10:37: SaveShortcutPath.
Action ended 18:10:37: SaveShortcutPath. Return value 1.
Action 18:10:37: FixShortcutWorkingDirectory.
Action start 18:10:37: FixShortcutWorkingDirectory.
DEBUG: Error 2851: The data for the icon WixUI_Ico_Info is not valid
The installer has encountered an unexpected error installing this package. This may indicate a problem with this package. The error code is 2851. The arguments are: WixUI_Ico_Info, ,
Error 1720. There is a problem with this Windows Installer package. A script required for this install to complete could not be run. Contact your support personnel or package vendor. Custom action FixShortcutWorkingDirectory script error -2147024891, WshShortcut.Save: Unable to save shortcut "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\PowerShell\PowerShell 6.0.1-c876ae3.lnk". Line 8, Column 9,
MSI (s) (8C:24) [18:10:39:239]: Product: PowerShell-6.0.1-c876ae3-x64 -- Error 1720. There is a problem with this Windows Installer package. A script required for this install to complete could not be run. Contact your support personnel or package vendor. Custom action FixShortcutWorkingDirectory script error -2147024891, WshShortcut.Save: Unable to save shortcut "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\PowerShell\PowerShell 6.0.1-c876ae3.lnk". Line 8, Column 9,

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1-164-g7dc54b240297ce5d79ac3a567de781d6a3e7df23
OS                             Microsoft Windows 10.0.16299
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Activity

  1. iSazonov commented on Feb 3, 2018

    @iSazonov
    Ilya (iSazonov)
    on Feb 3, 2018
    Collaborator

    /cc Chris Duck (@gpduck) Christoph Bergmeister (@bergmeister)

  2. bergmeister commented on Feb 3, 2018

    @bergmeister
    Christoph Bergmeister (bergmeister)
    on Feb 3, 2018
    Contributor

    I saw the PR that added this VBScript but since I don't have much knowledge about it, I decided to not comment on it, therefore I cannot be of any help in this issue.
    What I would suggest is to have a simple smoke test (as part of the AppVeyor build or a feature test) that installs it via the /quiet option of msiexec.exe and checks that the exit code is 0 (if there was a problem then it would be something like 1603, etc). This should not be too expensive in terms of time (I guess around 15-20 seconds).

  3. iSazonov commented on Feb 3, 2018

    @iSazonov
    Ilya (iSazonov)
    on Feb 3, 2018
    Collaborator

    I see two errors and don't understand how they relate. First is bad icon format. Second error -2147024891 is access denied.

  4. gpduck commented on Feb 3, 2018

    @gpduck
    Chris Duck (gpduck)
    on Feb 3, 2018
    Contributor

    I'm getting the same error on my laptop, I'll see what I can come up with.

  5. iSazonov commented on Feb 3, 2018

    @iSazonov
    Ilya (iSazonov)
    on Feb 3, 2018
    Collaborator

    Steve Lee (@SteveL-MSFT) Could you please consider to introduce new label Area-Install or Area-Setup for issues with MSI and installation scripts?

  6. Ilya (iSazonov)
    added
    Issue-BugIssue has been identified as a bug in the product
    on Feb 3, 2018

  7. gpduck commented on Feb 3, 2018

    @gpduck
    Chris Duck (gpduck)
    on Feb 3, 2018
    Contributor

    Travis Plunk (@TravisEz13) can you test the build at https://ci.appveyor.com/project/PowerShell/powershell/build/v6.1.0-preview.7845/artifacts and verify that it is fixed?

  8. TravisEz13 commented on Feb 4, 2018

    @TravisEz13
    Travis Plunk (TravisEz13)
    on Feb 4, 2018
    MemberAuthor

    I'll try it when I get back to a windows machine.

  9. TravisEz13 commented on Feb 5, 2018

    @TravisEz13
    Travis Plunk (TravisEz13)
    on Feb 5, 2018
    MemberAuthor

    No error and it worked

  10. Travis Plunk (TravisEz13)
    added a commit that references this issue on Feb 7, 2018

    Msi installer: Add smoke test (#6105)

    8890981
  11. Luca Auer (Lolle2000la)
    added a commit that references this issue on Apr 24, 2018

    Keep uptodate (#1)

    56293f5

  12. bergmeister commented on May 12, 2018

    @bergmeister
    Christoph Bergmeister (bergmeister)
    on May 12, 2018
    Contributor

    Travis Plunk (@TravisEz13) PR #6203 has fixed this, therefore this issue can be closed now.

  13. TravisEz13 commented on May 14, 2018

    @TravisEz13
    Travis Plunk (TravisEz13)
    on May 14, 2018
    MemberAuthor

    Agreed

  14. Travis Plunk (TravisEz13)
    closed this as completedon May 14, 2018
  15. Ilya (iSazonov)
    added
    Resolution-FixedThe issue is fixed.
    on May 15, 2018
  16. Thatgfsj (Thatgfsj)
    added a commit that references this issue on Aug 6, 2026

    Msi installer: Add smoke test (PowerShell#6105)

    f05186b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIssue has been identified as a bug in the productResolution-FixedThe issue is fixed.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions