Skip to content

Add excluded source files to Full CLR build #670

Closed
Closed
Add excluded source files to Full CLR build#670
Labels
Issue-Enhancementthe issue is more of a feature request than a bugOS-WindowsResolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.WG-Maintainers-Buildspecific to affecting the build
Milestone
6.0.0-NiceToHave

Description

@vors
sergei (vors)
opened on Mar 15, 2016

Microsoft.PowerShell.Commands.Management

  • The file ControlPanelItemCommand.cs is excluded from all frameworks in Microsoft.PowerShell.Commands.Management
    because it has dependency on [Shell32.ShellFolderItem] for FullCLR builds.

Microsoft.PowerShell.GraphicalHost

"ManagementList/CommonControls/ExpanderButtonAutomationPeer.cs",
"ManagementList/CommonControls/ExpanderButton.cs",
"ManagementList/CommonControls/ExpanderButton.Generated.cs",
"ManagementList/Common/PopupControlButton.cs",
"ManagementList/Common/PopupControlButton.Generated.cs"

Excluded because they requires UIAutomationTypes.dll

https://github.com/PowerShell/PowerShell/blob/1cc454fbd2bfa98efa9d9252f192558e876edd58/docs/KNOWNISSUES.md#files-excluded-from-the-build

Activity

  1. sergei (vors)
    added
    WG-Maintainers-Buildspecific to affecting the build
    on Mar 15, 2016
  2. sergei (vors)
    self-assigned this
    on Mar 15, 2016

  3. vors commented on Mar 17, 2016

    @vors
    sergei (vors)
    on Mar 17, 2016
    CollaboratorAuthor

    After investigation, I found that Shell32 namespace is coming from Microsoft.PowerShell.Shell32.Interop.dll that's build from shldisp.tlb obj file outside of our source tree. I need help from somebody with deeper windows build knowledge to find it.

  4. sergei (vors)
    added
    help wanted
    on Mar 17, 2016
  5. Andy Jordan (andyleejordan)
    added this to the v0.6.0 milestone on Jun 9, 2016
  6. sergei (vors)
    removed
    help wanted
    on Jun 21, 2016
  7. sergei (vors)
    removed their assignment
    on Jun 21, 2016
  8. sergei (vors)
    modified the milestones: Future, v0.6.0 on Jun 21, 2016

  9. vors commented on Jun 21, 2016

    @vors
    sergei (vors)
    on Jun 21, 2016
    CollaboratorAuthor

    I added the source code and keep it excluded from build. We don't need it for GA, moving to future.

  10. Joey Aiello (joeyaiello)
    added
    Issue-Enhancementthe issue is more of a feature request than a bug
    OS-Windows
    on Sep 1, 2016
  11. sergei (vors)
    changed the title [-]Add controlpanelitemcommand.cs to Full CLR build[/-] [+]Add excluded source files to Full CLR build[/+] on Sep 21, 2016
  12. Steve Lee (SteveL-MSFT)
    modified the milestones: , post-6.0.0 on Oct 17, 2016

  13. vors commented on Mar 31, 2017

    @vors
    sergei (vors)
    on Mar 31, 2017
    CollaboratorAuthor

    Since we are removing fullclr build, this issue is not applicable anymore

  14. sergei (vors)
    closed this as completedon Mar 31, 2017
  15. sergei (vors)
    added
    Resolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.
    on Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Enhancementthe issue is more of a feature request than a bugOS-WindowsResolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.WG-Maintainers-Buildspecific to affecting the build

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions