Skip to content

Remove the type catalog generator #733

Closed

Description

The type catalog generator was written by Dongbo Wang (@daxian-dbw) because we do not have AppDomain.GetAssemblies(), which is tracked in dotnet/corefx#1784. If we can get this API exposed by .NET Core, then the entire type catalog generator can go away.

Activity

  1. andyleejordan commented on May 12, 2016

    @andyleejordan
    MemberAuthor

    Dongbo Wang (@daxian-dbw) This may now be doable, as GetReferencedAssemblies is now exposed.

  2. andyleejordan commented on Jun 29, 2016

    @andyleejordan
    MemberAuthor

    This will be doable when GetAssemblies comes back in the next major release of .NET Core 😄

  3. HemantMahawar commented on Oct 17, 2016

    @HemantMahawar
    Contributor

    Andy Jordan (@andschwa): Is this still relevant?

  4. andyleejordan commented on Oct 17, 2016

    @andyleejordan
    MemberAuthor

    Hemant Mahawar (@HemantMahawar) Yes; assigning to Dongbo Wang (@daxian-dbw) for any further follow-up.

  5. modified the milestones: post-6.0.0, on Mar 4, 2017
  6. removed
    Blockedblocked on something external to this repo
    Issue-BugIssue has been identified as a bug in the product
    on Mar 4, 2017
  7. removed this from the milestone on May 22, 2017
  8. joeyaiello commented on May 22, 2017

    @joeyaiello
    Contributor

    Workaround in place, not ideal, but no pressing need to do this work yet.

  9. iSazonov commented on Aug 20, 2018

    @iSazonov
    Collaborator

    Dongbo Wang (@daxian-dbw) Could you please add comment why we can not remove the type catalog and close the issue?

  10. daxian-dbw commented on Aug 31, 2018

    @daxian-dbw
    Member

    PowerShell Core allows the user to use any .NET Core framework built-in types without knowing whether the assembly containing that type is loaded. Also, tab completion for type names also depends on it.

    If the assembly is not loaded, powershell load the assembly for you because it's able to figure out which assembly the type is in through the type catalog.

    AppDomain.GetAssemblies cannot help us do that because it only returns loaded assemblies. Therefore, we need to keep the type catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Resolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.WG-Maintainers-Buildspecific to affecting the build

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions