Repository navigation
Export PSReadLine to changes to public project #996
Description
Activity
While extracting the history and making PSReadLine build stand-alone against the public reference assemblies, I got blocked by a weird .NET possible bug. Filed https://github.com/dotnet/corefx/issues/9658.
5 remaining items
- assigned and unassigned
on Sep 19, 2016 - modified the milestones: ,
on May 22, 2017 - added a commit that references this issue
on Jan 20, 2018 After this change, the easiest way to pull the Pester module from PowerShell Gallery is to add it to the file
src/Modules/PSGalleryModules.csprojbut as the result,- Pester module will be pulled every time
- the switch
CIused in the functionsStart-PSBuildRestore-PSModuleToBuild
will be useless and have to be removed.
Another option - probably a more accurate - is to create the new one csproj file - by analogy to
src/Modules/PSGalleryModules.csproj(the proposed name PSGalleryModulesCI.csproj) and add an additional parameter to the functionCopy-PSGalleryModulesthat will contain a path to csproj file (an equivalent of the current line 2484) and call the functionCopy-PSGalleryModulestwice when $CI will be used.In both options the functions
Restore-PSPesterRestore-GitModule
will be removed.
What do you think? Am I right?
My comment is related to #4618.
Wojciech Sciesinski (@it-praktyk) -
msbuild restorecaches the package locally, so if the cache already has the correct version, nothing is pulled.Furthermore, at least in AppVeyor (I'm not sure about Travis) - the cache is saved across builds, so we shouldn't see too many pulls from CI.
I think what I did for
PSReadLinecan be done forPesteras well and as you point out - that would get rid of some code inbuild.psm1- but I haven't looked as closely as you - maybe we don't need the-CIparameter assuming the nuget cache is working as I described.travis-cican cache... I started working on making it but never finished. The-CIparameter is to pull in Pester only during CI builds. The desire is to not ship pester with PowerShell and have people useInstall-Moduleto get pester.Can we leave Pester in debug builds? I don't like run
Restore-PSPesterevery time.- added a commit that references this issue
on Aug 6, 2026
This is just so I remember to do this for Jason Shirk (@lzybkr).