Replace OneGet assemblies with these generated by OneGet.org by jianyunt · Pull Request #2711 · PowerShell/PowerShell

Jianyun (jianyunt) · 2016-11-17T20:40:16Z

Removed PackageManagement source code
Removed existing PackageMangement test code and replace with 8 tests case as acceptance test.
Use Save-Module to pull down PackageMangement from myget.
Changed to alpha.11 in download.sh to enable use PowerShellGet and OneGet in the build

Fix
Issue #1355
Issue #2347

sergei (vors)

Overall, looks good to me

sergei (vors) · 2016-11-18T01:14:54Z

typo: Dsetination

sergei (vors) · 2016-11-18T01:15:29Z

You don't need () around log calls

sergei (vors) · 2016-11-18T01:15:57Z

that's cool 👍

sergei (vors) · 2016-11-18T01:21:42Z

I would flip the default behavior and make it -PSModuleRestore.
Very tiny Start-PSBuild should be the bare minimum of things sufficient to run PowerShell.
It also should be incremental-friendly.

changed to PSModuleRestore

sergei (vors) · 2016-11-18T22:43:07Z

This logic is not correct

~~On incremental builds, it would Silently not change the folder~~

When user provide a custom binDir, it will pollute parent directory.

Please, consider fix Start-PSPester to understand both -Publish and no-publish options.
It could be as simple as add -Publish switch.

I open a separate issue #2720 to track the problem in Start-PSPester. For now, the workaround works.

Ok, lets merge the Fix in #2723 and we can proceed with your changes then.

Please revert back 969ac05d706d968eb534e886b5a5b9a4ce14a5bc

sergei (vors) · 2016-11-18T22:44:11Z

Jianyun (@jianyunt) to avoid this in the future, please join Microsoft GitHub organization and make your membership public.

Manikyam Bavandla (bmanikm) · 2016-11-18T23:51:48Z

this is not needed as we are registering only if we there is no existing repo with the same source location.

If the repository exists, $needRegister is false. This code won't get executed.
Only the case when the same repo exists but is pointing to some other source location.

In reply to: 88761457 [](ancestors = 88761457)

Manikyam Bavandla (bmanikm) · 2016-11-18T23:54:19Z

can be simplified with below
log "Unregistering PSRepository with name: $RepositoryName"
PowerShellGet\Get-PSRepository -Name $RepositoryName -ErrorAction SilentlyContinue | PowerShellGet\UnRegister-PSRepository -Name $RepositoryName

sure. Will integrate it

In reply to: 88761662 [](ancestors = 88761662)

Manikyam Bavandla (bmanikm) · 2016-11-19T01:19:31Z

…ules from myget

# The first commit's message is: Changed to PSModuleRestore switch, i.e., by default no PSModule install # This is the commit message #2: install PowerShell modules to publish folder as well as one level up # This is the commit message #3: removed workaround

sergei (vors) · 2016-11-19T01:55:26Z

+# Check if the PackageManagement works in the base-oS or PowerShellCore
+$PSHome
+$PSVersionTable
+$env:PSModulePath


It's better to remove these lines. They will pollute the test output.

sergei (vors) · 2016-11-19T07:25:23Z

        $publishPath = Split-Path $Options.Output -Parent
        log "Restore PowerShell modules to $publishPath"
        Restore-PSModule -Name PackageManagement -Destination (Join-Path -Path $publishPath -ChildPath "Modules")
+        Restore-PSModule -Name PowerShellGet -Destination (Join-Path -Path $publishPath -ChildPath "Modules")


Can you, please, make Name parameter a string[] and pass an array of strings

Fixed it in 391a787

No errors if brew dependencies already present

Microsoft Contribution License Agreements (msftclas) added the cla-required label Nov 17, 2016

Jason Shirk (lzybkr) added this to the 6.0.0-alpha.13 milestone Nov 17, 2016

PowerShellTeam added the Review - Needed label Nov 17, 2016

sergei (vors) reviewed Nov 18, 2016

View reviewed changes

sergei (vors) self-assigned this Nov 18, 2016

sergei (vors) suggested changes Nov 18, 2016

View reviewed changes

Jianyun (jianyunt) added cla-not-required and removed cla-required labels Nov 18, 2016

sergei (vors) suggested changes Nov 18, 2016

View reviewed changes

sergei (vors) added Review - Waiting on Author and removed Review - Needed labels Nov 18, 2016

Manikyam Bavandla (bmanikm) reviewed Nov 18, 2016

View reviewed changes

PowerShellTeam added Review - Needed and removed Review - Waiting on Author labels Nov 19, 2016

Jianyun (jianyunt) added 7 commits November 18, 2016 17:48

Update build.psm1 to pull PackageManagement assemblies

66f922b

Use alpha.11 instead of alpha.12 to allow using OneGet to install mod…

f850d56

…ules from myget

update project.json

a2efa9a

Add PackageManagement acceptance test cases

5229570

remove PackageManagement source code

0ec62d2

remove packagemanagement test code

e3706e8

sergei (vors) reviewed Nov 19, 2016

View reviewed changes

sergei (vors) approved these changes Nov 19, 2016

View reviewed changes

Jianyun (jianyunt) added 2 commits November 18, 2016 18:57

add psmodulerestore in travis.ps1

7160295

Removed PowerShellGet source and replaced with ones from myget

de331a8

sergei (vors) suggested changes Nov 19, 2016

View reviewed changes

Make Restore-PSModule -Name parameter a [string[]]

391a787

Make Start-PSBootstrap on macOS better

69e1ed3

No errors if brew dependencies already present

sergei (vors) merged commit 471594c into PowerShell:master Nov 20, 2016

sergei (vors) mentioned this pull request Nov 20, 2016

Decouple the bundled modules to seperate Repo's #1979

Closed

6 of 17 tasks

baophucct (baophucct) mentioned this pull request Mar 29, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 baophucct/PowerShell#9

Open

ajesse11x mentioned this pull request Mar 30, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 ajesse11x/PowerShell#8

Open

baophucct (baophucct) mentioned this pull request May 13, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 baophucct/PowerShell#10

Open

ajesse11x mentioned this pull request May 13, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 ajesse11x/PowerShell#9

Open

baophucct (baophucct) mentioned this pull request May 22, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 baophucct/PowerShell#11

Open

ajesse11x mentioned this pull request May 22, 2024

[Snyk] Security upgrade gulp from 4.0.0 to 5.0.0 ajesse11x/PowerShell#10

Open

Conversation

Jianyun (jianyunt) commented Nov 17, 2016

Uh oh!

sergei (vors) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei (vors) Nov 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei (vors) commented Nov 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Manikyam Bavandla (bmanikm) commented Nov 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sergei (vors) Nov 18, 2016 •

edited

Loading