Repository navigation
Add alpine preview image - #37
Merged
Travis Plunk (TravisEz13) merged 7 commits intoSep 11, 2018
Merged
Conversation
Travis Plunk (TravisEz13)
requested a review
from Andrew (anmenaga)
as a code owner
September 7, 2018 22:07
Steve Lee (SteveL-MSFT)
requested changes
Sep 7, 2018
| && apk -X https://dl-cdn.alpinelinux.org/alpine/edge/main add --no-cache \ | ||
| lttng-ust | ||
|
|
||
| RUN apk add --no-cache \ |
There was a problem hiding this comment.
Please combine these
| # TODO: once the official build produces a full package for alpine, remove this region | ||
|
|
||
| # Download the powershell .tar.gz package | ||
| RUN curl -L -o /tmp/powershell.tar.gz https://github.com/TravisEz13/PowerShell/releases/download/v6.1.0-rc.1/powershell-6.1.0-fixalpine-linux-musl-x64.tar.gz |
There was a problem hiding this comment.
Can we replace curl with ADD?
| FROM alpine:3.8 | ||
|
|
||
| ARG PS_VERSION=6.1.0-rc.1 | ||
| ARG PS_VERSION_POSTFIX=-1.ubuntu.16.04 |
There was a problem hiding this comment.
remove references to 16.04
Member
Author
|
Steve Lee (@SteveL-MSFT) I addressed your comments and I believe I fixed the build break |
Steve Lee (SteveL-MSFT)
approved these changes
Sep 10, 2018
Andrew (anmenaga)
approved these changes
Sep 10, 2018
|
|
||
| # Define Args for the needed to add the package | ||
| ARG PS_VERSION=6.1.0-rc.1 | ||
| # TODO: once the official build produces a full package for alpine, update this to the full package |
There was a problem hiding this comment.
This comment is kind of misleading as the next line IS the full package. Or am i missing something?
| # NOTE: the alpine tar.gz when this was written doesn't contain the modules. For that we need a container with modules. | ||
| # To accomplish this, we will get the modules from the full linux tar.gz package, then | ||
| # overlay the alpine tar.gz on top of it. | ||
| # There are TODO's in the file on updates that should occure one the Alpine .tar.gz contains everything |
Steve Lee (SteveL-MSFT)
requested changes
Sep 11, 2018
| # Define Args for the needed to add the package | ||
| ARG PS_VERSION=6.1.0-rc.1 | ||
| # TODO: once the official build produces a full package for alpine, update this to the full package | ||
| # TODO: once the official build produces a full package for alpine, update this to the full apline package |
Steve Lee (SteveL-MSFT)
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add alpine preview image
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.