Skip to content

ci: fix build and tests - #1731

Merged
eitsupi merged 1 commit into
masterfrom
fix/macos-ci-vscode-tests
Sep 19, 2026
Merged

eitsupi merged 1 commit into
masterfrom
fix/macos-ci-vscode-tests

Conversation

@eitsupi

@eitsupi eitsupi commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

  • update @vscode/test-electron to 3.1.0 so current macOS bundles are launched through CFBundleExecutable
  • run Xvfb only on Linux and run tests directly on macOS and Windows
  • move CI to Node.js 24 and Node 24-based v5 official actions
  • remove the obsolete programmatic test runner left after the vscode-test CLI migration

Root cause

VS Code 1.110 renamed the macOS executable from Electron to Code.
The compatibility symlink was subsequently removed, while @vscode/test-electron 2.5.2 continued to launch Contents/MacOS/Electron.

As a result, VS Code 1.138 downloaded successfully on macOS ARM64, but failed with ENOENT before the Mocha integration suite started.

@vscode/test-electron 3.1.0 resolves the executable using the app bundle's CFBundleExecutable, while retaining compatibility with older bundles.

@eitsupi

eitsupi commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

See also #1732

@eitsupi
eitsupi requested review from Fred-Wu and randy3k September 19, 2026 07:53
@eitsupi
eitsupi merged commit 17437a1 into master Sep 19, 2026
5 checks passed
@eitsupi
eitsupi deleted the fix/macos-ci-vscode-tests branch September 25, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants