Skip to content

ci: publish daily Marketplace pre-releases with odd minor versions - #1833

Merged
eitsupi merged 3 commits into
REditorSupport:mainfrom
eitsupi:feat/daily-marketplace-prerelease
Oct 6, 2026
Merged

eitsupi merged 3 commits into
REditorSupport:mainfrom
eitsupi:feat/daily-marketplace-prerelease

Conversation

@eitsupi

@eitsupi eitsupi commented Oct 6, 2026

Copy link
Copy Markdown
Member

Closes #1751.

Publish daily pre-releases to the VS Code Marketplace so users can receive development updates automatically.

  • Add a daily workflow that skips unchanged revisions and runs the existing build, lint, and cross-platform tests before publishing.
  • Generate odd-minor versions such as 3.1.YYYYMMDD by rewriting package.json only during packaging. Stable patch releases remain independent.
  • Validate that stable releases use an even minor version and that the release tag matches package.json.
  • Preserve the existing per-push GitHub development builds and document channel switching and versioning.

The workflow reuses VSCE_TOKEN. Retries retain the original UTC build date and tolerate an already-published version.

@eitsupi
eitsupi requested review from Fred-Wu, randy3k and renkun-ken and a lite review from Copilot October 6, 2026 13:37

This comment was marked as low quality.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflows, version ordering, retry behavior, validation, documentation, and tests are consistent and complete.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@eitsupi
eitsupi marked this pull request as ready for review October 6, 2026 13:48

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c00f3ccfa6e6ff7fc6b8419cf944c131675cc26b. I found no blocking defects in the changed code. The odd/even minor scheme, packaging-only version rewrite, verification gates, and duplicate handling are consistent with #1751.

Validation:

  • All five extension-version tests passed.
  • Packaged the PR revision with vsce package --pre-release --no-dependencies, confirmed version 3.1.20261006 and Microsoft.VisualStudio.Code.PreRelease=true in the VSIX, and passed the packaged sess source-identity check.
  • Executed the actual prepare shell step with mocked GitHub API responses for seven cases: first publication, unchanged revision, changed revision, retry retaining its original date, retry older than a successful run, an already-covered date, and a change after a skipped day.

The existing Copilot permission finding appears to be a false positive. The pinned artifact action authenticates uploads with ACTIONS_RUNTIME_TOKEN, rather than GITHUB_TOKEN; actions: write is not needed for this upload. Keep the current permissions. The overview's status-filter concern also does not apply: the workflow-runs API explicitly accepts conclusions such as status=success, which I also verified against the repository's runs.

Build, lint, Linux tests, and Windows tests have passed; macOS tests were still pending when checked. Actual scheduled execution and registry publication still need to be verified after merging.

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@eitsupi
eitsupi merged commit 32f198e into REditorSupport:main Oct 6, 2026
5 checks passed
@renkun-ken

renkun-ken commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

@eitsupi Is it possible to trigger the pre-release somehow so that we can check if the publishing works properly?

@eitsupi

eitsupi commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

@eitsupi Is it possible to trigger the pre-release somehow so that we can check if the publishing works properly?

I deliberately didn't add a workflow dispatch trigger this time, but I think it would be fine to add one.

@eitsupi

eitsupi commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

#1834

@eitsupi
eitsupi deleted the feat/daily-marketplace-prerelease branch October 6, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish regular pre-release builds to VS Code Marketplace

3 participants