Repository navigation
fix: install sess only the bundled source snapshot - #1840
Conversation
eitsupi
changed the title
renkun-ken
left a comment
renkun-ken
left a comment
There was a problem hiding this comment.
Found one reproducible regression in ordinary-terminal installation; details and the fix are inline.
Validated locally on macOS with R 4.6.1: all 6 source/bootstrap/VSIX identity tests, R/tests/sess_source.R, the bundled installer regression script, and real private-runtime installation/cache reuse passed under the normal default-package configuration. With R_DEFAULT_PACKAGES=base and library(utils) in the project's .Rprofile, the real ordinary R installation task installs sess successfully but fails in the new verifier; qualifying utils::packageDescription makes the same task pass.
CI: Ubuntu tests, build, and lint passed. The Windows job's bundled installer test passed; its failure is a 15-second timeout in Session Communication / communication: plot() with various devices and View() events (https://github.com/REditorSupport/vscode-R/actions/runs/37552130867/job/112569850311). macOS CI is still running at the time of this review.
renkun-ken
left a comment
renkun-ken
left a comment
There was a problem hiding this comment.
Reviewed through c5c4a92. The earlier P2 finding is resolved: all metadata lookups now use utils::packageDescription(), and the new regression coverage verifies both ordinary and Interactive paths with R_DEFAULT_PACKAGES=base. The latest commit also fixes the line-length failure while preserving the generated verifier expression. I found no remaining actionable issues.
Validation on macOS with R 4.6.1: the updated bundled installer regression script passes, including both minimal-default-package checks, exact-revision rejection, dependency-error propagation, and bundled-install failure handling. The real ordinary R installation task now passes with R_DEFAULT_PACKAGES=base and library(utils) in the project's .Rprofile. The source/bootstrap/VSIX identity tests (6/6), R identity/installer tests, and full R-directory lint also passed.
At the current head, GitHub build and lint checks have passed; macOS, Ubuntu, and Windows test jobs are still running. Approval reflects the code review and completed validation, with those platform results pending.
2 participants
vscode-R's installer could replace a failed bundled sess installation with a separately published R-universe package, whose source snapshot may differ from the extension's bundle.
Following #1819 and #1830, installation now uses the bundled pure-R package exclusively.
Missing Imports still use
install.packages()with the existing repository and library selection.Dependency errors propagate, a failed bundled
R CMD INSTALLstops directly, and the shared fresh-R verifier checks the exact bundled source revision alongside the existing API/load checks for ordinary terminals and private Interactive runtimes.Removes fallback-only repository discovery, binary compatibility logic, archive fixtures, and tests; updates current documentation and messages. Standalone R-universe installation instructions, badge,
bootstrap.R, source stamping, and DESCRIPTION normalization identity tests remain intact.Repository propagation, library placement, and runtime caching are unchanged.