Skip to content

warning when compiling fread on master on windows rtools42 #5374

Closed
#5395
Closed
warning when compiling fread on master on windows rtools42#5374
#5395
Labels
freadplatform-specific
Milestone
1.15.0

Description

@tdhock
tdhock
opened on Apr 26, 2022
> remotes::install_github("Rdatatable/data.table@e9a323de01a17af70d5316016606fa8d35b25023")
...
gcc  -I"c:/PROGRA~1/R/R-42~1.0/include" -DNDEBUG     -I"c:/rtools42/x86_64-w64-mingw32.static.posix/include"  -fopenmp   -O2 -Wall  -std=gnu99 -mfpmath=sse -msse2 -mstackrealign  -c fread.c -o fread.o
In file included from fread.h:3,
                 from fread.c:27:
dt_stdio.h:25: warning: "__USE_MINGW_ANSI_STDIO" redefined
   25 |   #define __USE_MINGW_ANSI_STDIO 1
      | 
In file included from c:\rtools42\x86_64-w64-mingw32.static.posix\include\corecrt.h:10,
                 from c:\rtools42\x86_64-w64-mingw32.static.posix\include\crtdefs.h:10,
                 from c:\rtools42\x86_64-w64-mingw32.static.posix\include\time.h:9,
                 from c:\rtools42\x86_64-w64-mingw32.static.posix\include\sys\time.h:10,
                 from fread.c:8:
c:\rtools42\x86_64-w64-mingw32.static.posix\include\_mingw.h:435: note: this is the location of the previous definition
  435 | #define __USE_MINGW_ANSI_STDIO 0      /* was not defined so it should be 0 */
      |

Activity

  1. tdhock
    added
    platform-specific
    on Apr 26, 2022
  2. tdhock
    added
    fread
    on May 4, 2022
  3. tdhock
    changed the title [-]warning when compiling master on windows rtools42[/-] [+]warning when compiling fread on master on windows rtools42[/+] on May 4, 2022

  4. tdhock commented on May 25, 2022

    @tdhock
    tdhock
    on May 25, 2022
    MemberAuthor

    It is possible to see this warning if you look on the GLCI log https://gitlab.com/Rdatatable/data.table/-/jobs/2212133398#L169 but it would be easy to miss (build is still green/pass). @jangorecki maybe it is worth considering changing the GLCI logic to return a red/fail build when there are compilation warnings, so that they would be more easily identified and fixed?

  5. jangorecki commented on May 26, 2022

    @jangorecki
    jangorecki
    on May 26, 2022
    Member

    We already have this logic for the most strict job:

    data.table/.gitlab-ci.yml

    Line 167 in e9a323d

    - (! grep "warning:" data.table.Rcheck/00install.out)

    We could add it for windows as well. As long as there won't be many false positives then it should be ok.

  6. mattdowle
    added this to the 1.14.3 milestone on Jul 20, 2022
  7. mattdowle
    closed this as completedin #5395on Jul 20, 2022
  8. jangorecki
    modified the milestones: 1.14.9, 1.15.0 on Oct 29, 2023

  9. jangorecki commented on Dec 6, 2023

    @jangorecki
    jangorecki
    on Dec 6, 2023
    Member

    @tdhock by any chance if you are on windows, could you provide powershell equivalent of

    (! grep "warning:" data.table.Rcheck/00install.out)

    ?
    note that we do have grep.exe from /c/Rtools43/bin. Maybe it is as simple as adding .exe but I don't have where to try out

  10. ben-schwen commented on Dec 6, 2023

    @ben-schwen
    ben-schwen
    on Dec 6, 2023
    Member

    @tdhock by any chance if you are on windows, could you provide powershell equivalent of

    (! grep "warning:" data.table.Rcheck/00install.out)

    ? note that we do have grep.exe from /c/Rtools43/bin. Maybe it is as simple as adding .exe but I don't have where to try out

    That should be -not (Get-Content "data.table.Rcheck\00install.out" | Select-String "warning:")

    -not (c:\Rtools43\bin\grep "warning:" data.table.Rcheck\00install.out) should also work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    freadplatform-specific

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions