as_tibble.data.table() method?  #5698

Activity

1. jangorecki commented on Oct 4, 2023

   

   jangorecki

   on Oct 4, 2023

   Last edited by jangorecki

   Member

   More actions

   Adding such method means extending dependencies of DT. We rather would like to reduce them, also Suggested dependencies. In this case there are many recursive dependencies as well.

   Is there a reason why as_tibble.data.frame method doesn't work?
   going via data.frame should work after looking at as.data.frame.data.table and what is under

   data.table/R/data.table.R

   Line 2799 in 8803918

   setattr(x, ".internal.selfref", NULL)

   ---

   I believe there reason is presented by this minimal example, which doesn't need tibble to reproduce:

   library(data.table)
   data(mpg, package = "ggplot2")
   
   mpg2 <- copy(mpg)
   identical(mpg, mpg2)
   #> [1] TRUE
   
   setDT(mpg2)
   mpg2 = as.data.frame(mpg2)
   identical(mpg, mpg2)
   #> [1] FALSE
2. MichaelChirico commented on Oct 4, 2023

   

   MichaelChirico

   on Oct 4, 2023

   Member

   More actions

   Isn't this the Enhances: dependency, and isn't the direction reversed, i.e., {data.table} would provide as.data.table.tibble() and {tibble} would provide as_tibble.data.table()?
3. jangorecki commented on Oct 4, 2023

   

   jangorecki

   on Oct 4, 2023

   Last edited by jangorecki

   Member

   More actions

   So the problem is that initial dataset to which you want to compare to isn't just data.frame. If we use normal data.frame it works as expected.

   iris2 = copy(iris)
   identical(iris, iris2)
   # [1] TRUE
   
   setDT(iris2)
   iris2 = as.data.frame(iris2)
   identical(iris, iris2)
   # [1] TRUE

   if as_tibble would go via as.data.frame then all should work seamlessly, but it must be dispatching to second class attribute "data.frame" instead.
   Defining the following should be sufficient

   as_tibble.data.table = function(x) as_tibble(as.data.frame(x))

   because as.data.frame.data.table method handles removing its attributes.

   I believe this problem is not only related to data.table but any package that defines class extending data.frame and uses custom attributes. as_tibble will assume it is standard data.frame and not go via as_tibble.default. Therefore to resolve problem at the root it should be rather something like that

   as_tibble.data.frame = function(x) {
     if (!identical(class(x), "data.frame")) return(as_tibble(as.data.frame(x)))
     ... # continue old as_tibble.data.frame body
   }

   ---

   I noticed data.table would suffer from the same issue as tibble so I filled #5699 so problem can be addressed nicely without needing any package to add dependencies.

   👍React with 👍1Reacted by Tim Taylor
4. jangorecki commented on Oct 4, 2023

   

   jangorecki

   on Oct 4, 2023

   Member

   More actions

   Indeed proposed one line change works as expected: https://github.com/Rdatatable/data.table/pull/5700/files
5. TimTaylor commented on Oct 25, 2023

   

   TimTaylor

   on Oct 25, 2023

   Last edited by TimTaylor

   Contributor

   More actions

   @jangorecki - do you want to raise this suggestion over at {tibble}? (I'm happy to do so if you'd prefer not to but didn't want to jump in over the top).
6. TimTaylor

   added a commit that references this issue on Oct 27, 2023

   Fixes tidyverse#1556

   ...

   ab8d05c
7. AngelFelizR commented on Nov 4, 2023

   

   AngelFelizR

   on Nov 4, 2023

   Contributor

   More actions

   Thanks @TimTaylor

   @ccsarapas I think that this issue is ready to be closed.

   👍React with 👍1Reacted by Jan Gorecki
8. jangorecki

   closed this as completedon Nov 7, 2023
9. krlmlr

   added a commit that references this issue on Dec 19, 2023

   Fixes tidyverse#1556

   ...

   990d733