Skip to content

cut off NEWS.md file #5775

Description

@jangorecki

It is getting too long IMO reaching as back as v1.10.0 (03 Dec 2016).

Activity

  1. added this to the 1.15.0 milestone on Nov 30, 2023
  2. TysonStanley commented on Dec 5, 2023

    @TysonStanley
    Member

    I agree. If someone wants a history lesson on data.table there are other sources ;) Should we keep a five year NEWS.md?

  3. MichaelChirico commented on Dec 5, 2023

    @MichaelChirico
    Member

    I think the idea is to truncate the current file as (e.g.) NEWS.1.md and continue on, similar to how r-devel does it.

  4. TysonStanley commented on Dec 5, 2023

    @TysonStanley
    Member

    Makes sense. So would we keep 1 or 2 years in the NEWS.md while putting the rest into NEWS.1.md? Looks like NEWS.0.md has 8 years of notes so unlikely to be much of a guide that way.

  5. MichaelChirico commented on Dec 6, 2023

    @MichaelChirico
    Member
  6. jangorecki commented on Dec 6, 2023

    @jangorecki
    MemberAuthor

    Or just keep all history of 3+ years in NEWS.0.md

  7. self-assigned this
    on Dec 8, 2023
  8. MichaelChirico commented on Dec 8, 2023

    @MichaelChirico
    Member

    Or just keep all history of 3+ years in NEWS.0.md

    GitHub UI struggles with huge files, better to keep a few around IMO.

  9. jangorecki commented on Dec 8, 2023

    @jangorecki
    MemberAuthor

    but CTRL+F is easier for single file on the other hand, and so old entries are rarely needed

  10. MichaelChirico commented on Dec 8, 2023

    @MichaelChirico
    Member

    Even loading huge files can be very slow. tests.Rraw is always causing issues. Current total length of NEWS.0 + NEWS is ~5,000 lines.

    old entries are rarely needed

    Yes, but "how old is old"? We also don't want to create a lot of churn in git history by e.g. copy-pasting an "old" release NEWS from "current" to "old" file. I'd rather this "relegation" happen rarely and exactly once.

  11. MichaelChirico commented on Dec 8, 2023

    @MichaelChirico
    Member

    Honestly with the change of maintainer I think we have a good enough reason to just rename NEWS on v<=1.14.10 as NEWS.1 and continue onward with new NEWS in 1.15.0+.

    OTOH, we should make sure we don't need any more patches in 1.14.x series before we commit to the new file, so let's table this for closer to the 1.15.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions