Repository navigation
Initialize data->fn_rows in rbindlist (fixes #2019) - #2077
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2077 +/- ##
==========================================
+ Coverage 90.58% 90.61% +0.03%
==========================================
Files 58 58
Lines 11055 11055
==========================================
+ Hits 10014 10018 +4
+ Misses 1041 1037 -4
Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.fn_rowsis initialized here:https://github.com/Rdatatable/data.table/blob/master/src/rbindlist.c#L505
However, this loop has a conditional break, resulting in
data.fn_rows[i]being undefined if not set inhttps://github.com/Rdatatable/data.table/blob/master/src/rbindlist.c#L524
which again is only executed conditionally (continue in L517+L519).
This may lead to a segfault while writing values to the id column in https://github.com/Rdatatable/data.table/blob/master/src/rbindlist.c#L770
and https://github.com/Rdatatable/data.table/blob/master/src/rbindlist.c#L778.