Repository navigation
Tweak allocation of initial buffers when nrows argument is provided - #2244
Merged
Merged
Conversation
…ordingly, and make sure that initialBuffRows cannot become 0. Closes #2243
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
==========================================
+ Coverage 90.73% 90.74% +0.01%
==========================================
Files 59 59
Lines 11511 11513 +2
==========================================
+ Hits 10445 10448 +3
+ Misses 1066 1065 -1
Continue to review full report at Codecov.
|
Do not reduce the number of rows sampled, otherwise we may not detect the types correctly.
mattdowle
approved these changes
Jul 8, 2017
mattdowle
left a comment
mattdowle
left a comment
Member
There was a problem hiding this comment.
Changes requested were made, thanks. That fread should still sample whole file as normal even if only a few rows are requested by nrows. For type consistency if the user is grabbing the file in sections using skip and nrows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When nrows argument is provided, reduce the number of jump points accordingly, and make sure that initialBuffRows cannot become 0.
Closes #2243