Skip to content

Prevent crash/malformed string when input line contains % character - #2288

Merged
mattdowle merged 6 commits into
masterfrom
fread2287
Aug 9, 2017
Merged

mattdowle merged 6 commits into
masterfrom
fread2287

Conversation

@st-pasha

@st-pasha st-pasha commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

Closes #2287

@st-pasha st-pasha added the fread label Aug 9, 2017
@st-pasha st-pasha added this to the v1.10.6 milestone Aug 9, 2017
@st-pasha
st-pasha requested a review from mattdowle August 9, 2017 19:06
@st-pasha st-pasha self-assigned this Aug 9, 2017
@codecov-io

codecov-io commented Aug 9, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #2288 into master will increase coverage by 0.07%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2288      +/-   ##
==========================================
+ Coverage   90.92%   90.99%   +0.07%     
==========================================
  Files          60       60              
  Lines       11778    11783       +5     
==========================================
+ Hits        10709    10722      +13     
+ Misses       1069     1061       -8
Impacted Files Coverage Δ
src/freadR.c 93.07% <100%> (ø) ⬆️
src/fread.c 93.52% <83.33%> (+0.03%) ⬆️
src/rbindlist.c 88.93% <0%> (+0.19%) ⬆️
src/bmerge.c 96.92% <0%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca174f...dc088c0. Read the comment docs.

@mattdowle mattdowle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mattdowle
mattdowle merged commit f366d05 into master Aug 9, 2017
@mattdowle
mattdowle deleted the fread2287 branch August 9, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants