Skip to content

Replace %zd/%zu in snprintf() with %lld, - #2301

Merged
mattdowle merged 3 commits into
masterfrom
issue2299
Aug 14, 2017
Merged

mattdowle merged 3 commits into
masterfrom
issue2299

Conversation

@st-pasha

Copy link
Copy Markdown
Contributor

because Windows does not recognize these format strings, and in some situations this may even result in a crash.

Closes #2299

…ecognize

these format strings, and in some situations this may even result in a crash.
@st-pasha st-pasha added the fread label Aug 14, 2017
@st-pasha st-pasha added this to the v1.10.6 milestone Aug 14, 2017
@st-pasha
st-pasha requested a review from mattdowle August 14, 2017 21:23
@st-pasha st-pasha self-assigned this Aug 14, 2017
@codecov-io

codecov-io commented Aug 14, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #2301 into master will increase coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
+ Coverage   90.92%   90.95%   +0.03%     
==========================================
  Files          61       61              
  Lines       11798    11800       +2     
==========================================
+ Hits        10727    10733       +6     
+ Misses       1071     1067       -4
Impacted Files Coverage Δ
src/fread.c 93.82% <75%> (+0.29%) ⬆️
src/rbindlist.c 88.93% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348c0c7...b6092cb. Read the comment docs.

@mattdowle
mattdowle merged commit 2b6fe0e into master Aug 14, 2017
@mattdowle
mattdowle deleted the issue2299 branch August 14, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants