Repository navigation
Make fread handle cases when allocnrow is too small - #2355
Merged
Merged
Conversation
…allocated for a DT turned out to be less than needed
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 91.14% 91.15% +0.01%
==========================================
Files 61 61
Lines 11808 11833 +25
==========================================
+ Hits 10762 10786 +24
- Misses 1046 1047 +1
Continue to review full report at Codecov.
|
mattdowle
requested changes
Sep 13, 2017
| DTPRINT("[11] Read the data\n"); | ||
| DTPRINT(" jumps=[%d..%d), chunk_size=%llu, total_size=%llu\n", jump0, nJumps, (llu)chunkBytes, (llu)(lastRowEnd-pos)); | ||
| } | ||
| ASSERT(allocnrow <= nrowLimit); |
Member
There was a problem hiding this comment.
Need the values of allocnrow and nrowLimit included in the error message please if assert fails.
mattdowle
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allocateDTis modified to handle the case when it is called with a different number ofnrowsthan previouslyallocateDTwith a new estimated number of columns; and finally restart the main reading loop from exactly the same point where we have left, avoiding the need to rescan the entire file again.nJumps,chunkBytesandlastRowEnd-posCloses #2246