Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
+ Coverage 91.58% 91.59% +<.01%
==========================================
Files 63 63
Lines 12029 12031 +2
==========================================
+ Hits 11017 11020 +3
+ Misses 1012 1011 -1
Continue to review full report at Codecov.
|
st-pasha
approved these changes
Nov 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2464
Adds 9 tests with variations including abrupt ending after final quote (
finalByte=='"').I was tempted to add more
&& ch==eof(or similar) in this PR in the cold or tepid sections but will delay until we have tests for embedded'\0'(i.e. before the final*eof=='\0').