Skip to content

Auto fill too few column names - #2580

Merged
mattdowle merged 7 commits into
masterfrom
auto_fill_header
Jan 23, 2018
Merged

mattdowle merged 7 commits into
masterfrom
auto_fill_header

Conversation

@mattdowle

@mattdowle mattdowle commented Jan 21, 2018 •

Copy link
Copy Markdown
Member

Closes #1625
Closes #1818
Closes #763

#1416 has more complex nuances I'll leave for another time.

@mattdowle mattdowle added this to the v1.10.6 milestone Jan 21, 2018
@codecov-io

codecov-io commented Jan 21, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #2580 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
+ Coverage   91.42%   91.43%   +0.01%     
==========================================
  Files          63       63              
  Lines       12111    12126      +15     
==========================================
+ Hits        11073    11088      +15     
  Misses       1038     1038
Impacted Files Coverage Δ
src/fread.c 96.02% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c6dc4...bdc3f39. Read the comment docs.

@mattdowle mattdowle closed this Jan 21, 2018
@mattdowle mattdowle reopened this Jan 21, 2018
@mattdowle

Copy link
Copy Markdown
Member Author

The close and reopen was this AppVeyor workaround, which worked.

@mattdowle
mattdowle requested a review from st-pasha January 21, 2018 07:56
@mattdowle

Copy link
Copy Markdown
Member Author

Probably more common than the example in #1625 are the examples in #1818, #763 and #1416 where the first column is a row name or index with a missing column name. If there is just one column name missing, changing the fill to be on the left.

@mattdowle
mattdowle merged commit b3b04c8 into master Jan 23, 2018
@mattdowle
mattdowle deleted the auto_fill_header branch January 23, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants