Repository navigation
\r no longer squashed in a single-column \r-only file - #2588
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
+ Coverage 91.43% 91.45% +0.01%
==========================================
Files 63 63
Lines 12126 12130 +4
==========================================
+ Hits 11088 11093 +5
+ Misses 1038 1037 -1
Continue to review full report at Codecov.
|
st-pasha
approved these changes
Jan 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2542
The single line ending
\r\r\r(when no\nis present) is no longer supported.\r\r\rnow means three line endings not one. It's only when\roccurs before or after a\ndo multiple\rstill get squashed (as is necessary when R'sdownload.file()turns\r\ninto\r\r\non Windows in text mode).This nicely revealed a few incorrectly passing tests on regular
\n1-column files with multiple\n\nat the end which should have been interpreted as NA at the end now that change is in dev. Fixed too.