Repository navigation
Better column name detection - #2596
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
+ Coverage 91.45% 91.48% +0.02%
==========================================
Files 63 63
Lines 12130 12137 +7
==========================================
+ Hits 11093 11103 +10
+ Misses 1037 1034 -3
Continue to review full report at Codecov.
|
st-pasha
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2526
The types in the potential-column-name line are now compared to the types after all the sample lines have been processed, rather than comparing to just the first data line. In order to ascertain types for the column name line after sampling, a common function was needed:
detect_types().The too-few or too-many fields message when reading data is now constructed in the ordered section so that a reliable line number is now given. Similarly, the error message from sampling jumps is now postponed to data reading stage so that a reliable line number can be given.