Skip to content

Fix bumping int->str on out-of-sample rows - #2615

Merged
mattdowle merged 2 commits into
masterfrom
issue2614
Feb 9, 2018
Merged

mattdowle merged 2 commits into
masterfrom
issue2614

Conversation

@st-pasha

@st-pasha st-pasha commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

Closes #2614

@st-pasha st-pasha added this to the v1.10.6 milestone Feb 8, 2018
@st-pasha st-pasha self-assigned this Feb 8, 2018
@st-pasha
st-pasha requested a review from mattdowle February 8, 2018 23:53
@codecov-io

codecov-io commented Feb 9, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #2615 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
+ Coverage   92.94%   92.94%   +<.01%     
==========================================
  Files          61       61              
  Lines       12107    12109       +2     
==========================================
+ Hits        11253    11255       +2     
  Misses        854      854
Impacted Files Coverage Δ
src/fread.c 96.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e93f0...5e1030b. Read the comment docs.

@mattdowle mattdowle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and fix!

@mattdowle
mattdowle merged commit c4ae884 into master Feb 9, 2018
@mattdowle
mattdowle deleted the issue2614 branch February 9, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants