Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 94.59% 94.59% +<.01%
==========================================
Files 61 61
Lines 11735 11736 +1
==========================================
+ Hits 11101 11102 +1
Misses 634 634
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3216
Closes #3217
I had added irows=NULL ability (all rows) to CsubsetDT but that made the rownames attribute c(NA, 0) since length(irows) was 0. Should have been c(NA, -n).
There were tests for
DT[,-"col"]but they compared to aDT[, otherCols]result. rownames became missing on both sides, so the tests still passed.