Skip to content

overAlloc in CsubsetDT - #3229

Merged
mattdowle merged 2 commits into
masterfrom
alloccol
Dec 17, 2018
Merged

mattdowle merged 2 commits into
masterfrom
alloccol

Conversation

@mattdowle

Copy link
Copy Markdown
Member

Closes #3228
CsubsetDT used a hard coded 64. Now it gets the value from options("datatable.alloccol") (1024 by default) which restores the past value and avoids the reduction in dev.
Thanks to @renkun-ken's testing.

@mattdowle mattdowle added this to the 1.12.0 milestone Dec 17, 2018
@codecov

codecov Bot commented Dec 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #3229 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12076    12088      +12     
==========================================
+ Hits        11430    11442      +12     
  Misses        646      646
Impacted Files Coverage Δ
R/data.table.R 95.18% <100%> (ø) ⬆️
src/assign.c 94.66% <100%> (+0.09%) ⬆️
src/subset.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e48f0...4ee2097. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Dec 17, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #3229 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12076    12088      +12     
==========================================
+ Hits        11430    11442      +12     
  Misses        646      646
Impacted Files Coverage Δ
R/data.table.R 95.18% <100%> (ø) ⬆️
src/assign.c 94.66% <100%> (+0.09%) ⬆️
src/subset.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e48f0...4ee2097. Read the comment docs.

@mattdowle
mattdowle merged commit 08197bd into master Dec 17, 2018
@renkun-ken renkun-ken mentioned this pull request Dec 17, 2018
@jangorecki
jangorecki deleted the alloccol branch June 3, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant