Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3900 +/- ##
=========================================
- Coverage 99.42% 99.4% -0.03%
=========================================
Files 72 72
Lines 13502 13642 +140
=========================================
+ Hits 13425 13561 +136
- Misses 77 81 +4
Continue to review full report at Codecov.
|
Member
|
Decrease in coverage is false; that's just because we didn't merge master into this PR so it's comparing this older branch against latest master. In this case, due to the nature of this PR, fine to skip. Coverage will update on master after merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testfunction from https://github.com/Rdatatable/data.table/wiki/Contributing intoman/test.Rd(the proper place for function documentation)test'smessagearg to be just after thewarning, to stack exceptions togethertest.data.table(with.other.packages,benchmark)pkg="pkg"to a nicer defaultpkg="."- maybe we could remove that argument at all?testfunction is insensitive for NaN vs NA difference #2960 by documenting behaviour