Skip to content

print gcc version during install, towards #3291 - #4162

Merged
mattdowle merged 1 commit into
masterfrom
conf-gcc-version
Jan 7, 2020
Merged

mattdowle merged 1 commit into
masterfrom
conf-gcc-version

Conversation

@jangorecki

Copy link
Copy Markdown
Member

towards #3291

@codecov

codecov Bot commented Jan 7, 2020

Copy link
Copy Markdown

Codecov Report

Merging #4162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4162   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          72       72           
  Lines       13915    13915           
=======================================
  Hits        13851    13851           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b7ad5...0cb50b1. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.9 milestone Jan 7, 2020
@mattdowle
mattdowle merged commit 59e7c83 into master Jan 7, 2020
@mattdowle
mattdowle deleted the conf-gcc-version branch January 7, 2020 22:55
Comment thread configure
Comment on lines +80 to +84
# compiler info to output #3291
if [ "$CC"=~"gcc" ]; then
GCCV=`${CC} -dumpfullversion -dumpversion`
echo "$CC $GCCV"
fi

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelChirico any idea if it works in macosx bash?
there is a report #4410 (comment)
which seems to not print gcc version (see in link). I double checked that /usr/local/gfortran/bin/gcc satisfies "$CC"=~"gcc" condition on my ubuntu.

@MichaelChirico MichaelChirico May 12, 2020 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I looking for? here is my output on OSX before the clang ... -c -o commands

R CMD INSTALL . --preclean
* installing to library ‘/Library/Frameworks/R.framework/Versions/4.0/Resources/library’
* installing *source* package ‘data.table’ ...
** using staged installation
zlib 1.2.11 is available ok
OpenMP supported
/usr/local/opt/llvm/bin/clang -fopenmp 4.2.1
** libs

I guess that second-last line is the $CC printout

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't detect clang, user is using gcc but for some reason it is still not being printed to output

@MichaelChirico MichaelChirico May 12, 2020 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried using /usr/local/gfortran/bin/gcc instead, here's my ~/.R/Makevars after:

GCC_LOC=/usr/local/gfortran
CC=$(GCC_LOC)/bin/gcc -fopenmp
CXX=$(GCC_LOC)/bin/g++ -fopenmp
CFLAGS=-g -O3 -Wall -pedantic -std=gnu99 -mtune=native -pipe
CXXFLAGS=-g -O3 -Wall -pedantic -std=c++11 -mtune=native -pipe
LDFLAGS=-L/usr/local/opt/gettext/lib -L$(GCC_LOC)/lib -Wl,-rpath,$(GCC_LOC)/lib
CPPFLAGS=-I/usr/local/opt/gettext/include -I$(GCC_LOC)/include

and then the same preamble output from R CMD INSTALL . --preclean:

* installing to library ‘/Library/Frameworks/R.framework/Versions/4.0/Resources/library’
* installing *source* package ‘data.table’ ...
** using staged installation
zlib 1.2.11 is available ok
OpenMP supported
/usr/local/gfortran/bin/gcc -fopenmp 6.3.0
** libs

@jangorecki jangorecki May 12, 2020 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it is casued by early exit

if [ $msg -ne 0 ]; then
  ...
  exit 0

thanks

@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants