Repository navigation
Remove importClassesFrom entry in NAMESPACE - #6004
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6004 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 80 80
Lines 14873 14873
=======================================
Hits 14498 14498
Misses 375 375 ☔ View full report in Codecov by Sentry. |
Member
|
thanks for investigating! |
Member
Author
|
Going ahead to merge here, no news from downstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the r-package-devel thread:
https://stat.ethz.ch/pipermail/r-package-devel/2024q1/010581.html
The proper approach for the downstream is to use
.datatable.aware=TRUEto accomplish what they're after (ensuring[.data.tabledispatches as intended).I filed a PR with downstream to correct the issue:
yikeshu0611/do#2
I think we should go ahead and merge this for 1.16.0, but let's leave it pending for now while we give downstream maintainer some time to respond.