Repository navigation
Message fixes for the C code - #6504
Conversation
Otherwise it's very hard to translate without pgettext() in a language where "there is no <x>" is translated as "<x> is absent"
This will avoid potential word order issues.
.Last.value is a variable in the global environment. .Last.updated belongs to the data.table package.
|
Generated via commit 384fe62 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 22 seconds Time taken to run |
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Thanks! A few small questions. Fixes basically look good.
MichaelChirico
added
the
translation
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: rikivillalba <[email protected]>
Hopefully the compiler will be smart enough to inline it back. Co-authored-by: Michael Chirico <[email protected]>
Forgot to take #6504 (comment) into account.
|
Don't regenerate the .pot file in this PR, save it for a follow-up |
| if (verbose) { | ||
| Rprintf(_("%zu by excluding 0 and 1 counts\n"), MSBsize); | ||
| } | ||
| MSBsize = shrinkMSB(MSBsize, msbCounts, order, verbose); |
There was a problem hiding this comment.
I might have assumed this helper would be by-reference on MSBsize; OTOH, it's a single size_t and this is only done once in fsort(). The impact should not be noticed.
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Great work + progress! I think this is ready to merge. We can always do more PRs with more fixes :)
4 participants
This solves some of the obvious issues in #6503. I can expand on the more tough or less obvious ones when we decide which ones to fix and how.
po/data.table.pot