Skip to content

Early returns to reduce nesting and improve readability - #6542

Merged
tdhock merged 2 commits into
masterfrom
i18n-
Oct 1, 2024
Merged

tdhock merged 2 commits into
masterfrom
i18n-

Conversation

@MichaelChirico

Copy link
Copy Markdown
Member

Seen while reading for #6503

@codecov

codecov Bot commented Sep 27, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (3734726) to head (6fb4e26).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6542   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14448    14449    +1     
=======================================
+ Hits        14249    14250    +1     
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown

Comparison Plot

Generated via commit 6fb4e26

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 3 minutes and 19 seconds

Time taken to run atime::atime_pkg on the tests: 8 minutes and 58 seconds

@MichaelChirico MichaelChirico changed the title Early returns to reduce nesting to improve readability Early returns to reduce nesting and improve readability Sep 28, 2024

@tdhock tdhock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

@tdhock
tdhock merged commit d62aac9 into master Oct 1, 2024
@MichaelChirico
MichaelChirico deleted the i18n- branch July 8, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants