Repository navigation
Add tools and parallel to Suggests, #7288 - #7403
Closed
ANAMASGARD wants to merge 1 commit into
Closed
ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
- tools used in fread and frollapply - parallel used in frollapply - Added 4 tests (2345.01-2345.04) to verify functionality - Updated NEWS.md with change notes These packages were being used without being declared in DESCRIPTION. Note: adding parallel to Suggests may affect codecov CI jobs per issue discussion - this requires monitoring.
Member
|
What's is exactly the purpose of those unit tests? Btw. Did you read contributing documentation? More precisely the first paragraph of https://github.com/Rdatatable/data.table/blob/master/.github/CONTRIBUTING.md#pull-requests-prs |
Member
|
Dear Gauarv Chaudhary,
Thank you for your motivation and effort!
data.table is almost 20 years old; it's probably impossible by now for
a single person to fit the entire program in their head, and most of
the remaining problems are not at all easy to solve, even if it's
sometimes easy to see what's wrong. This is one of those issues: if not
for covr problems, we would have already marked the dependency on
'parallel'.
Instead of trying to fix covr (which will require knowledge of fork()
semantics and ability to debug concurrency problems), try your hand at
issues marked with the "beginner-task" label that aren't yet taken:
https://github.com/Rdatatable/data.table/issues?q=state%3Aopen%20label%3Abeginner-task
|
Member
|
No reply for a while, once our feedback will be addressed we can reopen PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7288
Summary
Adds
toolsandparallelpackages to the Suggests field in DESCRIPTION as these packages are used internally but were not declared as dependencies.Changes
toolsandparallelto DESCRIPTION Suggests fieldPackage Usage
tools: used internally byfreadandfrollapplyparallel: used internally byfrollapplyTesting
Local test results: All 12,072 tests pass including new tests 2345.01-2345.04
Note on Codecov
As mentioned by @jangorecki in the issue, adding
parallelto Suggests may cause codecov CI jobs to hang. This is a known upstream issue with thecovrpackage that will need to be monitored in CI. If the hang occurs, a minimal reproducible example should be submitted to the covr repository as suggested in the issue discussion.These packages were being used without being declared in DESCRIPTION. Note: adding parallel to Suggests may affect codecov CI jobs per issue discussion - this requires monitoring.