Skip to content

example(groupingsets): limit the number of threads - #7632

Merged
MichaelChirico merged 1 commit into
masterfrom
groupingsets-CPU-time
Jan 26, 2026
Merged

example(groupingsets): limit the number of threads#7632
MichaelChirico merged 1 commit into
masterfrom
groupingsets-CPU-time

Conversation

@aitap

@aitap aitap commented Jan 26, 2026

Copy link
Copy Markdown
Member

https://win-builder.r-project.org/incoming_pretest/data.table_1.18.2.1_20260125_054833/reverseDependencies/package/00check.log

* checking examples ... [14s/10s] NOTE
Examples with CPU time > 2.5 times elapsed time
              user system elapsed ratio
groupingsets 4.613  0.144    0.98 4.854

Tested manually by setting DTthreads to 99 with a debugger, then running system.time(example(groupingsets)).

@aitap
aitap requested a review from MichaelChirico as a code owner January 26, 2026 13:32
@aitap aitap mentioned this pull request Jan 26, 2026
Closed
@MichaelChirico
MichaelChirico merged commit c90c52e into master Jan 26, 2026
8 checks passed
@MichaelChirico
MichaelChirico deleted the groupingsets-CPU-time branch January 26, 2026 18:45
@aitap aitap mentioned this pull request Aug 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aitap @MichaelChirico