Skip to content

.net standard support #76

Description

@yar1k0v

Hi, is there any plans on porting the library to .net standard ?

Activity

  1. Jericho commented on Jul 4, 2017

    @Jericho

    I have forked the repo and I am investigating what it would take to support netstandard. I will list the issues I discover (if any).

  2. Jericho commented on Jul 4, 2017

    @Jericho

    Here are the issues I found that would need to be resolved to support netstandard:

    1. Several methods are decorated with [MethodImpl(MethodImplOptions.Synchronized)]. 'Synchronized' is not available in netstandard 1.6 (although it's rumored to be back in netstandard 2,0. I haven't verified)
    2. ConfigurationManager is not available in netstandard
    3. WebClient is not available in netstandard
    4. WebRequest is not available in netstandard
    5. HttpListener is not available in netstandard
    6. HttpListenerContext is not available in netstandard
    7. HttpListenerException is not available in netstandard
    8. HttpListenerRequest is not available in netstandard
    9. HttpListenerResponse is not available in netstandard
  3. alhardy commented on Jul 4, 2017

    @alhardy
    Contributor

    @yar1k0v @Jericho see here for a related discussion

  4. Crozin commented on Aug 25, 2017

    @Crozin
    Contributor

    I seems that .NET Standard 2.0 provides all necessary types except for ConfigurationManager.

  5. Crozin commented on Sep 27, 2017

    @Crozin
    Contributor

    Any chance for update? As far as I know ConfigurationManager is used only as a convnient way to set up Metrics.Reports.ToleratedConsecutiveFailures, Metrics.HttpListener.HttpUriPrefix and Metrics.GlobalContextName from appSettings. That could be ommited in .NET Standard 2.0.

  6. megakid commented on Oct 29, 2017

    @megakid

    I am working on this - current work in progress is here: https://github.com/megakid/Metrics.NET/tree/netcore

  7. rofr commented on Nov 10, 2017

    @rofr

    @megakid Is the port going well? Need any help? Looks like most work is in the samples and adapters..

  8. megakid commented on Nov 10, 2017

    @megakid

    @rofr I think the port is pretty much done but I don't have any experience with Nancy and Owin. I have introduced a new AspNetCore adapter, pretty much copy pasted from Owin and tweaked.

    Everything I have tested is working, I'll create a PR and would appreciate a review/comments.

  9. megakid commented on Nov 10, 2017

    @megakid

    #91 Pull Request created.

  10. rofr commented on Nov 10, 2017

    @rofr

    @megakid awesome, I'll have a look. I'll also tell the nancy dev team, maybe one of them can help review.

  11. elementum commented on Dec 30, 2017

    @elementum

    Any news on this?

  12. theazyfa commented on Jun 13, 2018

    @theazyfa

    any update?

  13. micdenny commented on Aug 7, 2018

    @micdenny

    here's my 2 cents:

    master...micdenny:netcore

    https://github.com/micdenny/Metrics.NET/tree/netcore

    I've just convertered the main project Metrics and in this way all the performance counters works on netcore webapi projects that is what I need right now (normal metrics works with the actual fullfx version). I've tried adding the shims, but then a problem with async start throwing, so I've tried to do the less step to convert the in project in netcore and I did it adding only Microsoft.CSharp, System.Configuration.ConfigurationManager and System.Diagnostics.PerformanceCounter on top of netstandard2.0

  14. yar1k0v commented on Feb 11, 2019

    @yar1k0v
    Author

    Looks like this project is dead.

  15. megakid commented on Feb 11, 2019

    @megakid

    We've moved to https://www.app-metrics.io/ which was forked from this project.

  16. cocowalla commented on Feb 11, 2019

    @cocowalla

    @megakid so... I'm confused - I thought this repo was continuing under @Recognos, while the app-metrics.io fork was created by someone else after some disagreements about how/when .NET Standard support should be implemented?

  17. megakid commented on Feb 11, 2019

    @megakid

    @megakid so... I'm confused - I thought this repo was continuing under @Recognos, while the app-metrics.io fork was created by someone else after some disagreements about how/when .NET Standard support should be implemented?

    I'm not sure of the origins of app-metrics vs metrics.net but app-metrics is similar enough (API wise), seems to be more active and works well for us (e.g. my day job) in production. The number 1 reason we migrated away from this project is because we want to proceed with .NET Core ASAP and Metrics.NET was our main blocker.

    I originally planned to do some work on Metrics.NET to help the .NET Core migration but wasn't able to devote much time to it, then we found app-metrics...

  18. cocowalla commented on Feb 12, 2019

    @cocowalla

    @megakid ah, I took "We've moved" to mean "we the original repo owners have moved"

  19. yar1k0v commented on Feb 15, 2019

    @yar1k0v
    Author

    @megakid I know this project and my team is going to migrate on it as well since this project is not supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions