Skip to content

Adding an override for the ssh port - #1432

Merged
NGPixel merged 2 commits into
requarks:masterfrom
wallrick:ssh-configure-port
Feb 3, 2020
Merged

NGPixel merged 2 commits into
requarks:masterfrom
wallrick:ssh-configure-port

Conversation

@wallrick

@wallrick wallrick commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

Problem:

  • Trying to use git storage feature with a private git server with ssh running on a non-default port. Git over ssh typically happens on port 22 however non-standard setups can use a custom port number. Wiki.js doesn't support adding custom SSH port while setting up the git storage.

Solution:

  • Added an option on the git storage configuration page to allow specifying ssh port. It is optional and empty by default with port 22 used by default if nothing specified.

Testing:

  • Manually validated that the setting is properly picked up.
  • Tested with custom and default ports and everything worked as expected.

Possible future improvement:

  • Adding an advanced ssh section on the git storage page and rolling this configuration into that would be a possible way of simplifying the UI.

@auto-assign
auto-assign Bot requested a review from NGPixel February 3, 2020 02:37
@NGPixel
NGPixel merged commit b1c7eda into requarks:master Feb 3, 2020
@craviee

craviee commented Apr 26, 2023

Copy link
Copy Markdown

This was removed somehow? I'm using version 2.5.170 which should have it but it doesn't.

jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
* Adding an override for the ssh port

* fix: git module - ssh custom port

Co-authored-by: Nicolas Giard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants