Skip to content

Reflection*::getNamespaceName() returns null when no namespace - namespace as empty string is implemented only in adapters - #1219

Merged
Ocramius merged 1 commit into
Roave:6.0.xfrom
kukulich:namespace
Sep 23, 2022
Merged

Ocramius merged 1 commit into
Roave:6.0.xfrom
kukulich:namespace

Conversation

@kukulich

Copy link
Copy Markdown
Collaborator

I think the compatibility can be only in adapters.

@kukulich kukulich added this to the 6.0.0 milestone Sep 22, 2022
@kukulich
kukulich marked this pull request as ready for review September 22, 2022 19:50
@Ocramius Ocramius self-assigned this Sep 22, 2022
…space as empty string is implemented only in adapters
@Ocramius

Copy link
Copy Markdown
Member

Can't add more BC breaks to the milestone - wow Github, really? :D

@kukulich

Copy link
Copy Markdown
Collaborator Author

Mutation tests are green 🍾

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks! 🎉

@Ocramius
Ocramius merged commit 7bc326b into Roave:6.0.x Sep 23, 2022
@kukulich
kukulich deleted the namespace branch September 30, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants