Skip to content

Fixed detection of interface circular reference - #1269

Merged
kukulich merged 1 commit into
Roave:6.1.xfrom
kukulich:circular-interface
Oct 4, 2022
Merged

kukulich merged 1 commit into
Roave:6.1.xfrom
kukulich:circular-interface

Conversation

@kukulich

@kukulich kukulich commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

Fixes #1267

@kukulich kukulich added the bug label Oct 2, 2022
@kukulich kukulich added this to the 6.0.1 milestone Oct 2, 2022
@kukulich
kukulich force-pushed the circular-interface branch from 9713283 to 38b5af9 Compare October 2, 2022 10:38
@herndlm

herndlm commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

Thank you @kukulich
I see you also fixed what I did in #1265 too. Was that part of the problem as well?

@kukulich

kukulich commented Oct 2, 2022 •

Copy link
Copy Markdown
Collaborator Author

@herndlm I was not able to solve it without your Stringable fix. I've just force pushed your PR with the mutant fix. I hope it will make your build green and I'll rebase then.

@herndlm

herndlm commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

I see, thx. Yeah, no worries about my PR, I was just curious :)

@kukulich
kukulich force-pushed the circular-interface branch from 38b5af9 to cb9cdf3 Compare October 4, 2022 07:29
@kukulich
kukulich changed the base branch from 6.0.x to 6.1.x October 4, 2022 07:29
@kukulich kukulich modified the milestones: 6.0.1, 6.1.0 Oct 4, 2022
Comment thread src/Reflection/ReflectionClass.php Outdated
@kukulich
kukulich force-pushed the circular-interface branch from cb9cdf3 to b941631 Compare October 4, 2022 07:40

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kukulich
kukulich marked this pull request as ready for review October 4, 2022 07:56
@kukulich kukulich self-assigned this Oct 4, 2022
@kukulich
kukulich merged commit 877efaf into Roave:6.1.x Oct 4, 2022
@kukulich
kukulich deleted the circular-interface branch October 4, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not-circular interface detected as circular

3 participants