Repository navigation
Enhancement: Allow fetching constant name from exception - #570
Merged
Merged
Conversation
Ocramius
requested changes
May 6, 2020
localheinz
force-pushed
the
feature/constant
branch
from
May 6, 2020 16:44
95f070c to
5d98ff1
Compare
Ocramius
reviewed
May 6, 2020
localheinz
force-pushed
the
feature/constant
branch
from
May 6, 2020 17:14
5d98ff1 to
8e58d76
Compare
Ocramius
approved these changes
May 6, 2020
Ocramius
left a comment
Ocramius
left a comment
Member
There was a problem hiding this comment.
Accessor approach is indeed good enough for our purposes 👍
Member
|
Thanks @localheinz! |
Contributor
Author
|
Thank you, @Ocramius! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
UnableToCompileNodeexceptionFixes #569.