Skip to content

Methods are case insensitive, and should be mapped and looked up without considering casing - #601

Merged
Ocramius merged 1 commit into
Roave:masterfrom
kukulich:case-insensitive-methods
May 27, 2020
Merged

Ocramius merged 1 commit into
Roave:masterfrom
kukulich:case-insensitive-methods

Conversation

@kukulich

@kukulich kukulich commented May 27, 2020 •

Copy link
Copy Markdown
Collaborator

Fixes #588

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ocramius Ocramius changed the title Methods are case insensitive Methods are case insensitive, and should be mapped and looked up without considering casing May 27, 2020
@Ocramius Ocramius self-assigned this May 27, 2020
@Ocramius Ocramius added the bug label May 27, 2020
@Ocramius Ocramius added this to the 4.3.0 milestone May 27, 2020
@Ocramius
Ocramius merged commit 9854417 into Roave:master May 27, 2020
@Ocramius

Copy link
Copy Markdown
Member

Thanks, @kukulich! Excellent work!

@kukulich
kukulich deleted the case-insensitive-methods branch May 27, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReflectionClass::hasMethod(), getMethod() etc should be case insensitive

2 participants