Repository navigation
Support resource as constant value, make STDIN, STDOUT and STDERR stubs actual resources - #905
Merged
Merged
Conversation
Ocramius
requested changes
Dec 6, 2021
Ocramius
approved these changes
Dec 6, 2021
Ocramius
requested changes
Dec 6, 2021
Ocramius
left a comment
Ocramius
left a comment
Member
There was a problem hiding this comment.
A random CS issue appears!
FILE: ...src/SourceLocator/SourceStubber/PhpStormStubs/CachingVisitor.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
17 | ERROR | [x] Type define is not used in this file.
| | (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
19 | ERROR | [x] Type fopen is not used in this file.
| | (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Collaborator
Author
|
@Ocramius Already fixed and force pushed :) |
Ocramius
changed the title
resource as constant valueresource as constant value, make STDIN, STDOUT and STDERR stubs actual resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a little hack. I converted the
definecalls to this:define('STDIN', constant('STDIN'))And this format can be supported in stubs and then in both source stubbers.