Repository navigation
Add capAdapt test utility and framework_meshing C++14 requirement - #486
Merged
Merged
Conversation
- apf_cap/CMakeLists.txt: change how C++14 is enabled so that capAdapt
can compile against framework_meshing and get C++14.
- basically, framework_meshing interfaces require C++14 so this is
perfect.
- test/capAdapt.cc: add test utility.
- test/CMakeLists.txt: add capAdapt.
Signed-off-by: Aiden Woodruff <[email protected]>
- standardize cre2mds migration timer format. - add mds end to end timer. Signed-off-by: Aiden Woodruff <[email protected]>
- test/capAdapt.cc: remove stage and add log prefixes instead. - remove unused variables. - (makeApfInterfaceWithSizing): refactor apf::Mesh creation and size field loading into function. - (parallelAdapt): refactor 1->n partition, adapt, n->1 localize into function with timer. - destroy empty remote MDS meshes. Signed-off-by: Aiden Woodruff <[email protected]>
Signed-off-by: Aiden Woodruff <[email protected]>
Angelyr
reviewed
Jun 2, 2025
Angelyr
left a comment
Angelyr
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I didn't run into any issues using it. And it was easy to read.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add capAdapt test utility and framework_meshing C++14 requirement
capAdapttest utility to load Capstone mesh, convert to MDS, partition, adapt, join, convert back to and write CRE.framework_meshing: the headers use C++14 so it needs theINTERFACEcompile feature.capAdaptagainstframework_meshingto call smoothing directly and avoid converting to frame/scale fields between sizing.