Repository navigation
fix: Return HTTP response immediately without waiting for fault recovery - #565
Merged
Merged
Conversation
This change prevents the submission API from blocking while performing slow operations like fault injection/recovery and app teardown. These operations can take minutes when running multiple problems concurrently. Changes: - Add async cleanup method that performs fault recovery, undeploy, and cluster reconciliation in the background - Update _finish_problem to set state to tearing_down immediately and schedule async cleanup - Modify submit() to capture results snapshot and return immediately - Prevent noise restart during teardown state - Add tearing_down to possible stages in API documentation Fixes #244 Co-authored-by: Jackson Clark <[email protected]>
Collaborator
|
Found an error while working. The submit tool (SREGym/clients/stratus/tools/submit_tool.py) expects status to be 200. |
HacksonClark
marked this pull request as ready for review
February 16, 2026 22:17
Collaborator
|
@HacksonClark I'm testing this with a MS problem and a normal problem |
Member
Author
|
Closes #575 |
…EGym into claude/issue-244-20260213-2244
…EGym into claude/issue-244-20260213-2244
Collaborator
|
@HacksonClark can confirm that the previous broken MS problem now can correctly finish ( |
Collaborator
|
Closes #585 |
Collaborator
|
Testing three problems tonight to merge this.
|
This was referenced Feb 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the submission API from blocking while performing slow operations like fault injection/recovery and app teardown. These operations can take minutes when running multiple problems concurrently.
Changes
_finish_problemto set state to "tearing_down" immediately and schedule async cleanupsubmit()to capture results snapshot and return immediatelyFixes #244
Generated with Claude Code