Support Shift+Tab to remove tabs #6

Activity

1. avk commented on Aug 8, 2016

   

   avk

   on Aug 8, 2016

   ContributorAuthor

   More actions

   To support deleting tabs, I had to adapt my onTab handler to:

     handleTab(evt) {
       let newState;
       let { editorState } = this.state;
   
       if (evt.shiftKey) {
         // since backspace removes tabs in CodeUtils 
         // https://github.com/SamyPesse/draft-js-code/blob/9783c0f6bbedda6b7089712f9c657a72fdae636d/lib/handleKeyCommand.js#L11
         newState = CodeUtils.handleKeyCommand(editorState, 'backspace');
       } else {
         // let CodeUtils insert tabs
         newState = CodeUtils.handleTab(evt, editorState);
       }
   
       this.setState({
         editorState: newState,
       });
     }

   This logic feels like it should live in CodeUtils.handleTab. Thoughts?
2. mxstbr

   added

   enhancement

   help wanted

   on Sep 22, 2017
3. mxstbr commented on Sep 22, 2017

   

   mxstbr

   on Sep 22, 2017

   Collaborator

   More actions

   Yep, this looks perfect! Mind submitting a PR? Thank you!