Add Volume Limiter Support #353

Activity

1. Sapd commented on Jun 9, 2024

   

   Sapd

   on Jun 9, 2024

   Owner

   More actions

   Looks like there is a function in the device file but I don't see a way to execute it.

   Yeah the guy implementing it found it probably during his WireShark Session but didn't implement it as headsetcontrol currently has no command for that.

   You can feel free to add one (not really complicated, you can just copy the code for send_microphone_volume):

   • Add here a new funtion, similar to send_microphone_volume:

     HeadsetControl/src/device.h

     Line 324 in f64ac48

     int (*send_microphone_volume)(hid_device* hid_device, uint8_t num);

   • In the Arctis 7 file, reference the function you saw here:

     HeadsetControl/src/devices/steelseries_arctis_7.c

     Line 40 in f64ac48

     device_arctis.send_sidetone = &arctis_7_send_sidetone;

   • Also in device.h add a capbability just calling it CAP_VOLUME_LIMITER :

     HeadsetControl/src/device.h

     Line 38 in f64ac48

     CAP_MICROPHONE_VOLUME,

   • Now you just need to implement the parameter in main.c:
     • Add an option here { "volume-limiter", required_argument, NULL, 0 },

       HeadsetControl/src/main.c

       Line 529 in f64ac48

       { "microphone-volume", required_argument, NULL, 0 },

     • Handle that option here, simply copy the microphone volume code and rename things (and create a variable on top):

       HeadsetControl/src/main.c

       Lines 706 to 712 in f64ac48

       	} else if (strcmp(opts[option_index].name, "microphone-volume") == 0) {
       	microphone_volume = strtol(optarg, &endptr, 10);
       	if (*endptr != '\0' || endptr == optarg || microphone_volume < 0 || microphone_volume > 128) {
       	fprintf(stderr, "Usage: %s --microphone-volume 0-128\n", argv[0]);
       	return 1;
       	}

     • Also here:

       HeadsetControl/src/main.c

       Line 806 in f64ac48

       { CAP_MICROPHONE_VOLUME, CAPABILITYTYPE_ACTION, &microphone_volume, microphone_volume != -1, {} },

     • Then call your new function in handle feature:

       HeadsetControl/src/main.c

       Line 301 in f64ac48

       case CAP_MICROPHONE_VOLUME:

   Feel free if you struggle somewhere
2. nicola02nb commented on Jun 10, 2024

   

   nicola02nb

   on Jun 10, 2024

   Contributor

   More actions

   I created a pull request for some missing features of the Steelseries Artic Nova 7:

   • microphone mute led brightness
   • microphone volume
   • volume limiter

   🎉React with 🎉1Reacted by Lucas Hereld
3. nicola02nb commented on Jun 10, 2024

   

   nicola02nb

   on Jun 10, 2024

   Last edited by nicola02nb

   Contributor

   More actions

   @duckman all the feature for your headphones will be included with my pull request
4. duckman commented on Jun 10, 2024

   

   duckman

   on Jun 10, 2024

   Author

   More actions

   You sir are a gentleman and a scholar. I'll try it out tonight.
5. nicola02nb commented on Jun 10, 2024

   

   nicola02nb

   on Jun 10, 2024

   Contributor

   More actions

   If you want to checck out also my GUI you're welcome.
6. Sapd

   linked a pull request that will close this issueAdded capabilities for Artic Nova 7 mirophone(tested and working) and… #356on Jun 11, 2024
7. Sapd

   closed this as completedon Jun 11, 2024