Repository navigation
Fix intermittent deploy failures with shared UI extension folders - #8833
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8823.
app deploybuilds UI extensions concurrently. When two UI extensions share a folder, one build can move its source map back into the shared localdist/while another build copies that directory. The second copy may have already enumerated the map and then fail withENOENTwhen it tries to stat the temporarily moved file.WHAT is this pull request doing?
The UI bundle step now copies generated files individually and excludes
*.js.map. Source maps are already kept in the local output directory and excluded from deploy archives, so this preserves the shipped bundle contents while removing the concurrent read/write race. The regression test confirms that regular and nested assets still copy, source maps stay local, and maps are omitted from the bundle.The new regression test failed before the fix because the source map was copied into the bundle. It passes after the fix. The full
@shopify/appsuite passed (283 test files, 3,561 passed, 3 skipped); targeted ESLint, Prettier, type-check, and build also passed.How to manually test your changes?
Create an app with a single extension folder containing two UI extensions that generate source maps, then run
shopify app deploy. Repeat the deploy and confirm it no longer intermittently fails withENOENTwhile copying a sibling.js.mapfile.Post-release steps
None.
Checklist
@shopify/app.