Repository navigation
Remove return self functionality - #2278
Merged
Merged
Conversation
blowekamp
force-pushed
the
remove_return_self
branch
5 times, most recently
from
April 30, 2025 20:29
ae6a906 to
3401005
Compare
|
Errors:
|
Some Set method and Execute methods return "self" by reference, allowing for chained functions. This has been removed because in some situations the returned object can become invalid. Additionally, this was not supported by SWIG, and was not in any wrapped languages.
blowekamp
force-pushed
the
remove_return_self
branch
from
May 22, 2025 15:48
3401005 to
801b2c1
Compare
blowekamp
marked this pull request as ready for review
May 29, 2025 19:03
zivy
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Set method and Execute methods return "self" by reference, allowing for chained functions. This has been removed because in some situations the returned object can become invalid. Additionally, this was not supported by SWIG, and was not in any wrapped languages.